Prevent disabled device menus from opening - #2624
Conversation
shomix
commented
Aug 4, 2026
shomix
commented
- Disabled camera and microphone controls can no longer open device selection menus.
- This prevents the transparent dropdown from appearing when capture is turned off.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Here's a visual recap of what changed: Open the full interactive recap |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
![builder-io-integration[bot]](https://avatars.githubusercontent.com/in/353721?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Builder reviewed your changes — looks good ✅
Review Details
Incremental Code Review Summary
The updated PR refactors MediaDeviceRow so device selection and system-audio settings use separate controls. When camera or microphone capture is off, the device label button is disabled and the device list is omitted; when the microphone is off, a dedicated menu trigger remains available for the independent “Record System audio” switch. The new wrapper positioning also keeps the popover anchored to the complete row.
The previous review’s system-audio accessibility concern is addressed by this separation. Two parallel relaxed reviews found no new confirmed bugs across disabled-state behavior, menu state transitions, device selection/refresh, ARIA attributes, or CSS positioning. This remains a low-risk frontend change.
✅ Good fix: the microphone-off path now exposes only the applicable system-audio setting rather than reopening device selection.
✅ Existing close-on-toggle-off behavior is preserved.
🧪 Browser testing: Attempted full verification after the update, but all 10 grounded test cases were blocked because browser automation tools were unavailable to executor agents. The dev server was healthy; no visual evidence was collected.
2 participants
